ferruzzi commented on code in PR #23628:
URL: https://github.com/apache/airflow/pull/23628#discussion_r885101482
##########
airflow/providers/amazon/aws/operators/sagemaker.py:
##########
@@ -188,7 +193,7 @@ def execute(self, context: 'Context') -> dict:
)
if response['ResponseMetadata']['HTTPStatusCode'] != 200:
raise AirflowException(f'Sagemaker Processing Job creation failed:
{response}')
- return {'Processing':
self.hook.describe_processing_job(self.config['ProcessingJobName'])}
+ return {'Processing':
serialize(self.hook.describe_processing_job(self.config['ProcessingJobName']))}
Review Comment:
Sorry for the delay. I got caught up helping plan to AWS System Tests
migration, and then Airflow Summit. If I serialize the whole return value,
that's changing the return type and I don't know if that's a good idea. How do
you feel about the way it is now? I think it should be fixed up in the XCOM
code as well, I know I ran into similar issue ion the past where a timestamp in
an API return breaks an operator's XCOM serialization, so we should look into a
larger fix.
Can/should we apply this fix for Sagemaker for the time being and look at
XCOM later?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
