uranusjr commented on code in PR #23971:
URL: https://github.com/apache/airflow/pull/23971#discussion_r886324138
##########
airflow/hooks/dbapi.py:
##########
@@ -188,25 +206,21 @@ def run(self, sql, autocommit=False, parameters=None,
handler=None):
self.set_autocommit(conn, autocommit)
with closing(conn.cursor()) as cur:
- results = []
for sql_statement in sql:
+ results = []
self._run_command(cur, sql_statement, parameters)
if handler is not None:
result = handler(cur)
results.append(result)
Review Comment:
If we agree with 3, I think 1-ii should be `[None, (2,), None, (3,)]`
instead for consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
