ramandumcs commented on issue #5353: AIRFLOW-4586 There is no need to check 
explicitly for queued dependen…
URL: https://github.com/apache/airflow/pull/5353#issuecomment-500749047
 
 
   @ashb 
   It seems semantics of _check_and_change_state_before_execution function is 
to change the task state to None if RUN_DEPS are not met (so that it can be 
rescheduled). But It does not change anything if QUEUE_DEPS are not met. i.e 
task would remain in its current state. As per my understanding a task 
run(ti.run) can be triggered either by scheduler or through cmd line. And in 
_check_and_change_state_before_execution function we might not want to change 
the  state (if QUEUE_DEPS are not met) for tasks trigged via commandline.So it 
leaves their state as it is.
   We have seen couple of instances where task remained stuck in queued state 
and is picked up by scheduler after restart.
   We will debug it further and will check for alternate solutions.
   Just wanted to check if this understanding makes sense to you

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to