o-nikolas commented on PR #24058: URL: https://github.com/apache/airflow/pull/24058#issuecomment-1143885895
> it may be good idea to offer some kind of interface that would allow every provider to provide some function to retrieve/set env variable value before running the tests. That's outside of this PR - I'm just wondering what we can steal from some of the ideas from different PR to get some nice common solutions :) Thanks @bhirsz! While reviewing the System Test AIP the lack of a shared interface for environment setup was one of the things I brought up and I had some back and fourth about in the dev email discussion thread with Mateusz and Jarek ([link](https://lists.apache.org/thread/htd4013yn483qfhwv11vc26jpf2yvjph)). Ultimately the AIP stayed as it was and for AWS we designed this setup system for our provider tests. I'd love to abstract this into a more general interface, but we'd have to get buy-in from the others who were involved in that AIP first. I think it would be an easy lift too, the biggest piece would be plugging in the cloud paramater store of your choice (we used SSM but the Google folks likely want to use something else) and any specific requirements around the env_id format (what type of characters are allowed or not for the different provider components). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
