bharanidharan14 commented on code in PR #24038: URL: https://github.com/apache/airflow/pull/24038#discussion_r887598460
########## airflow/providers/microsoft/azure/hooks/asb_admin_client.py: ########## @@ -0,0 +1,83 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review Comment: In intial development stage `BaseAzureServiceBusHook` ,`AzureServiceBusAdminClientHook` and `ServiceBusMessageHook` was in same file after seeing the `AzureBaseHook` and other azure class I moved to different file :) . I am fine with your suggestion lets rename the class names and keep it under same file, lets wait for @josh-fell reply as well ########## airflow/providers/microsoft/azure/hooks/asb_admin_client.py: ########## @@ -0,0 +1,83 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review Comment: In initial development stage `BaseAzureServiceBusHook` ,`AzureServiceBusAdminClientHook` and `ServiceBusMessageHook` was in same file after seeing the `AzureBaseHook` and other azure class I moved to different file :) . I am fine with your suggestion lets rename the class names and keep it under same file, lets wait for @josh-fell reply as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
