koconder commented on code in PR #24185:
URL: https://github.com/apache/airflow/pull/24185#discussion_r889689804
##########
dev/breeze/src/airflow_breeze/commands/developer_commands.py:
##########
@@ -601,7 +602,13 @@ def run_shell(verbose: bool, dry_run: bool, shell_params:
ShellParams) -> RunCom
env_variables = get_env_variables_for_docker_commands(shell_params)
if cmd_added is not None:
cmd.extend(['-c', cmd_added])
-
+ if "arm64" in DOCKER_DEFAULT_PLATFORM:
Review Comment:
How do we maintain version check, do we know when its supported if someone
will know to remove this? Do we have a cleaner solution?
##########
dev/breeze/src/airflow_breeze/global_constants.py:
##########
@@ -102,18 +102,6 @@
"MSSQL_VERSION": "MSSql version",
}
-PARAM_NAME_FLAG = {
Review Comment:
Any reason this was removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
