dstandish commented on code in PR #24117:
URL: https://github.com/apache/airflow/pull/24117#discussion_r890484560
##########
airflow/models/taskinstance.py:
##########
@@ -400,6 +400,13 @@ def key(self) -> "TaskInstanceKey":
return self
+def executor_config_comparator(x, y):
+ try:
+ return x == y
+ except AttributeError:
Review Comment:
yeah if we were using our own PickleType then we'd be able to do that. but
we're using sqlalchemy's PickleType. Seems that it's not worth subclassing
when the class already provides a mechanism (i.e. compator) for handling this
kind of thing. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
