schattian commented on code in PR #23658:
URL: https://github.com/apache/airflow/pull/23658#discussion_r890881497
##########
airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##########
@@ -256,7 +293,7 @@ def consume_logs(*, since_time: Optional[DateTime] = None,
follow: bool = True)
time.sleep(1)
def await_container_completion(self, pod: V1Pod, container_name: str) ->
None:
- while not self.container_is_running(pod=pod,
container_name=container_name):
+ while self.container_is_running(pod=pod,
container_name=container_name):
Review Comment:
nice - yep, i though on doing so in a diff pr but im using that func.
Will rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
