potiuk commented on PR #23860:
URL: https://github.com/apache/airflow/pull/23860#issuecomment-1148501017

   > > This change requires all mapped operators on PythonOperators subclasses 
to be re-serialized. But this is likely a reasonable tradeoff over carrying 
complex compatibility code forever.
   > 
   > Will it break with the existing code or work fine? If it needs 
deserialization to make it work, should be run that as part of migration?
   
   Do we know how much time re-serialization takes even with big installations 
? 
   
   I REALLY think (and I've raised it before) we should always reserialize all 
dags with any migration. This issue will hit us back continuously, and we will 
- almost for sure - miss a lot of cases where we will not realise that 
reserialisation is needed. I believe preventting the problems and "always 
reserializing" is a better "default" solution. Maybe just with "minor" 
migrations but it should be automated and do the reserialisation "just in case" 
IMHO. it can even be acommpanied by a "--prevent-reserialization" flag to skip 
it, but it should be enabled by default as "preventive" step.  
   
   Just my 3 cents to the discussion. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to