uranusjr commented on code in PR #23574:
URL: https://github.com/apache/airflow/pull/23574#discussion_r891946340
##########
airflow/utils/db.py:
##########
@@ -854,7 +854,7 @@ def check_conn_id_duplicates(session: Session) ->
Iterable[str]:
)
-def reflect_tables(tables: List[Union[Base, str]], session):
+def reflect_tables(tables: Optional[List[Union[Base, str]]], session):
Review Comment:
Why is this `None` case needed? From what I can tell it’s the same as
`reflect_tables(tables=[])`. Using `None` is probably more straightforward at
the call site, but in that case we should change the condition in this function
to `if tables is None` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
