Taragolis commented on PR #24306: URL: https://github.com/apache/airflow/pull/24306#issuecomment-1149883919
> I believe there were quite a lot of refactorings to AwsBaseHook since and I guess this is result of it - looks legit for me actually. I've just check in 1.10.4 (I used to work with this version for about 1 year) and looks like it have the same behaviour https://github.com/apache/airflow/blob/1.10.4/airflow/contrib/hooks/emr_hook.py If user stored some parameters in EMR Connection which not accepted by `run_job_flow` it would receive an error. However after this changes: - If user will store `aws_access_key_id ` the error not happen (breaking changes?) https://github.com/apache/airflow/blob/287fc4bdeb107fc81653d3a6721f9f5b87b90529/airflow/providers/amazon/aws/hooks/emr.py#L101 - If user store other extra arguments from AWS Connection such as `region_name`, `profile_name`, `config_kwargs`, `session_kwargs`, and etc the error will raised I'm never been happy with behaviour that I need provide emr connection in cases when I do not required it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
