nclaeys commented on code in PR #22976:
URL: https://github.com/apache/airflow/pull/22976#discussion_r871428746
##########
airflow/executors/kubernetes_executor.py:
##########
@@ -689,9 +689,14 @@ def _change_state(self, key: TaskInstanceKey, state:
Optional[str], pod_id: str,
self.event_buffer[key] = state, None
def try_adopt_task_instances(self, tis: List[TaskInstance]) ->
List[TaskInstance]:
- tis_to_flush = [ti for ti in tis if not ti.queued_by_job_id]
- scheduler_job_ids = {ti.queued_by_job_id for ti in tis}
- pod_ids = {ti.key: ti for ti in tis if ti.queued_by_job_id}
+ scheduler_job_ids = {ti.queued_by_job_id for ti in tis if
ti.queued_by_job_id}
+
+ # Tasks triggered through API will have no ti.queued_by_job_id
+ # and their pod will have label 'airflow-worker=manual'
+ if any(ti for ti in tis if not ti.queued_by_job_id):
Review Comment:
I am not sure which issues you are talking about, which makes it difficult
for me to implement it. Also if you are speaking in general about
queued_by_job_id not being filled in than that is an issue for any executor, so
should that logic not reside in the scheduler code itself instead of in the
kubernetes_executor? At this moment I would feel uncomfortable adding that and
I believe it is a better fit in a separate ticket...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
