dstandish commented on code in PR #23574:
URL: https://github.com/apache/airflow/pull/23574#discussion_r892558847


##########
airflow/utils/db.py:
##########
@@ -854,7 +854,7 @@ def check_conn_id_duplicates(session: Session) -> 
Iterable[str]:
         )
 
 
-def reflect_tables(tables: List[Union[Base, str]], session):
+def reflect_tables(tables: Optional[List[Union[Base, str]]], session):

Review Comment:
   OK I guess i can see the case for `[]` means no tables.
   
   Consistent behavior.  e.g. in the dynamic case:
   ```
   metadata = reflect_tables([x[0] for x in models_list], session)
   ```
   
   well maybe there you don't need to bother reflecting any tables.
   
   updated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to