josh-fell commented on code in PR #23647:
URL: https://github.com/apache/airflow/pull/23647#discussion_r893550910
##########
tests/sensors/test_external_task_sensor.py:
##########
@@ -134,17 +134,36 @@ def
test_external_task_sensor_failed_states_as_success(self):
"unit_test_dag failed."
)
+ def test_external_task_sensor_soft_fail_failed_states_as_skipped(self,
session=None):
+ self.test_time_sensor()
+ op = ExternalTaskSensor(
+ task_id='test_external_task_sensor_check',
+ external_dag_id=TEST_DAG_ID,
+ external_task_id=TEST_TASK_ID,
+ allowed_states=[State.FAILED],
+ failed_states=[State.SUCCESS],
+ soft_fail=True,
+ dag=self.dag,
+ )
+
+ # when
+ op.run(start_date=DEFAULT_DATE, end_date=DEFAULT_DATE,
ignore_ti_state=True)
+
+ # then
+ session = settings.Session()
+ TI = TaskInstance
+ task_instances: list[TI] = session.query(TI).filter(TI.task_id ==
op.task_id).all()
+ assert len(task_instances) == 1, "Unexpected number of task instances"
+ assert task_instances[0].state == State.SKIPPED, "Unexpected external
task state"
+
def test_external_task_sensor_external_task_id_param(self):
"""Test external_task_ids is set properly when external_task_id is
passed as a template"""
self.test_time_sensor()
op = ExternalTaskSensor(
task_id='test_external_task_sensor_check',
external_dag_id='{{ params.dag_id }}',
external_task_id='{{ params.task_id }}',
- params={
- 'dag_id': TEST_DAG_ID,
- 'task_id': TEST_TASK_ID,
- },
+ params={'dag_id': TEST_DAG_ID, 'task_id': TEST_TASK_ID,},
Review Comment:
Of course. Maybe CI black likes the one line, maybe it doesn't. Let's see!
Totally fine if it comes back. If black is fine with the one line, I didn't
want you to get dinged for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
