Taragolis commented on code in PR #24057: URL: https://github.com/apache/airflow/pull/24057#discussion_r894848008
########## airflow/providers/amazon/aws/hooks/appflow.py: ########## @@ -0,0 +1,50 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from typing import TYPE_CHECKING + +from airflow.providers.amazon.aws.hooks.base_aws import AwsBaseHook + +if TYPE_CHECKING: + from mypy_boto3_appflow.client import AppflowClient + + +class AppflowHook(AwsBaseHook): + """ + Interact with Amazon Appflow, using the boto3 library + Hook attribute `conn` has all methods that listed in documentation + + .. seealso:: + - https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/appflow.html + - https://docs.aws.amazon.com/appflow/1.0/APIReference/Welcome.html + + Additional arguments (such as ``aws_conn_id`` or ``region_name``) may be specified and + are passed down to the underlying AwsBaseHook. + + .. seealso:: + :class:`~airflow.providers.amazon.aws.hooks.base_aws.AwsBaseHook` + + """ + + def __init__(self, *args, **kwargs) -> None: + kwargs["client_type"] = "appflow" + super().__init__(*args, **kwargs) + + @property + def conn(self) -> 'AppflowClient': + """Get the underlying boto3 Appflow client (cached)""" Review Comment: This connection property not cached anymore ```python from airflow.providers.amazon.aws.hooks.appflow import AppflowHook hook = AppflowHook(region_name="eu-west-1") conn = hook.conn assert conn is hook.conn, "AppflowHook conn property non-cached" ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
