ashb commented on a change in pull request #4890: [AIRFLOW-4048] HttpSensor
provide-context to response_check
URL: https://github.com/apache/airflow/pull/4890#discussion_r292992991
##########
File path: airflow/sensors/http_sensor.py
##########
@@ -81,8 +89,10 @@ def poke(self, context):
headers=self.headers,
extra_options=self.extra_options)
if self.response_check:
- # run content check on response
- return self.response_check(response)
+ if self.provide_context:
+ return self.response_check(response, context)
Review comment:
That was what you had before:
```python
response_check_kwargs["context"] = context
# ...
response_check(response, **response_check_kwargs)
```
which would still have the check fn having a signature of `(response,
context)`. I am proposing making it have a signature of `(response, **context)`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
