cswpy commented on code in PR #24363: URL: https://github.com/apache/airflow/pull/24363#discussion_r895096606
########## airflow/providers/google/cloud/operators/bigquery.py: ########## @@ -36,7 +36,7 @@ from airflow.models import BaseOperator, BaseOperatorLink from airflow.models.xcom import XCom from airflow.operators.sql import SQLCheckOperator, SQLIntervalCheckOperator, SQLValueCheckOperator -from airflow.providers.google.cloud.hooks.bigquery import BigQueryHook, BigQueryJob +from airflow.providers.google.cloud.hooks.bigquery import BigQueryHook, BigQueryJob, _split_tablename Review Comment: Thanks for the comment. Indeed, private functions are not meant to be imported. But there is no in-class function that could split the table name, which means I either import the private function or rewrite it in the current class. I suppose the former is more acceptable? Also, I do see that the code imported some other private functions as shown below. https://github.com/apache/airflow/blob/7fed7f31c3a895c0df08228541f955efb16fbf79/airflow/providers/google/cloud/operators/bigquery.py#L39-L41 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
