potiuk commented on code in PR #24386: URL: https://github.com/apache/airflow/pull/24386#discussion_r895501154
########## docs/__init__.py: ########## @@ -0,0 +1,16 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review Comment: > I also excluded docs from the "no relative imports rule" and converted the imports there to be relative in order to make "docs building utils" work fine with scripts and flake/isort without having to do some "noqa: excludes" The main reason was that isort produced different sorting order depending on was run on just "docs" or "all files". Simply sometimes "docs" were treated as implicit package in "airflow" and sometimes as standalone "implicit" package and sorting order depended on that (even adding "docs" as known package in setup.cfg did not help. converting docs to regular "standard" python package helped. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
