dstandish commented on PR #18615: URL: https://github.com/apache/airflow/pull/18615#issuecomment-1154152798
> My main concern here is that `env_vars` intentionally takes `List[V1EnvVar]` - taking a `dict` is currently for backward compatibility only at this point. It's not that we couldn't support this, but there was a conscious move to using the models from the k8s client. Jed if that's the case, I think we should have a deprecation warning and ultimately remove support for it. @alex-astronomer @RickRen7575 do you see any reason we would really need to maintain support for dict? Or do you think that ultimately we can remove it? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
