dstandish commented on code in PR #23317:
URL: https://github.com/apache/airflow/pull/23317#discussion_r896035280
##########
tests/always/test_example_dags.py:
##########
@@ -60,7 +60,7 @@ def test_should_be_importable(example):
@pytest.mark.parametrize("example", example_dags_except_db_exception(),
ids=relative_path)
def test_should_not_do_database_queries(example):
- with assert_queries_count(0):
+ with assert_queries_count(0,
ignore_patterns=['dagbag.py:validate_task_pools']):
Review Comment:
wait.... nevermind... as it is, we only make _one_ query at the end after
all DAG parsing has completed. so it's not like it's querying once for every
DAG. this to me seems pretty reasonable?
but I guess DagBag load doesn't only happen from the dag processor service,
but also perhaps when tasks are run.... so maybe there's something here to
optimize.
perhaps we could make it so that this kind of check is disabled except when
loading dagbag from dag processor service. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
