Fokko commented on a change in pull request #5410: [AIRFLOW-4781] Add the 
ability to specify ports in kubernetesOperator
URL: https://github.com/apache/airflow/pull/5410#discussion_r293223013
 
 

 ##########
 File path: airflow/kubernetes/pod_generator.py
 ##########
 @@ -62,6 +63,13 @@ def add_init_container(self,
     def _get_init_containers(self):
         return self.init_containers
 
+    def add_port(self, port):
 
 Review comment:
   Haven't had my coffee yet, I ment:
   We're introducing typehints into the Airflow codebase.
   ```suggestion
       def add_port(self, port: Port):
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to