josh-fell commented on code in PR #24416:
URL: https://github.com/apache/airflow/pull/24416#discussion_r896939077
##########
airflow/providers/google/cloud/transfers/bigquery_to_gcs.py:
##########
@@ -115,17 +178,49 @@ def execute(self, context: 'Context'):
location=self.location,
impersonation_chain=self.impersonation_chain,
)
- job: BigQueryJob = hook.run_extract(
- source_project_dataset_table=self.source_project_dataset_table,
- destination_cloud_storage_uris=self.destination_cloud_storage_uris,
- compression=self.compression,
- export_format=self.export_format,
- field_delimiter=self.field_delimiter,
- print_header=self.print_header,
- labels=self.labels,
- return_full_job=True,
+ self.hook = hook
+
+ configuration = self._prepare_configuration()
+ job_id = hook.generate_job_id(
+ job_id=self.job_id,
+ dag_id=self.dag_id,
+ task_id=self.task_id,
+ logical_date=context["logical_date"],
+ configuration=configuration,
+ force_rerun=self.force_rerun,
)
- conf = job["configuration"]["extract"]["sourceTable"]
+
+ try:
+ self.log.info(f"Executing: {configuration}")
Review Comment:
We should use %-formatting in logging so the formatting is deferred until
the latest possible moment.
##########
airflow/providers/google/cloud/transfers/bigquery_to_gcs.py:
##########
@@ -78,6 +93,7 @@ def __init__(
*,
source_project_dataset_table: str,
destination_cloud_storage_uris: List[str],
+ project_id: Optional[str] = None,
Review Comment:
Would you mind adding this to the operator's docstring too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
