LydiaSimmons523 commented on code in PR #24446:
URL: https://github.com/apache/airflow/pull/24446#discussion_r897912427
##########
airflow/providers/google/suite/hooks/drive.py:
##########
@@ -128,17 +128,19 @@ def get_media_request(self, file_id: str) -> HttpRequest:
request = service.files().get_media(fileId=file_id)
return request
- def exists(self, folder_id: str, file_name: str, drive_id: Optional[str] =
None):
+ def exists(self, folder_id: str, file_name: str, drive_id: Optional[str] =
None, include_trashed: Optional[bool] = False):
Review Comment:
I think having it not consider the trashed files is a sensible default.
Also, this will avoid breaking existing code that calls this method on the hook.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
