tanelk commented on code in PR #23846:
URL: https://github.com/apache/airflow/pull/23846#discussion_r901259845
##########
tests/jobs/test_scheduler_job.py:
##########
@@ -381,6 +381,68 @@ def test_process_executor_event_missing_dag(self,
mock_stats_incr, mock_task_cal
ti1.refresh_from_db()
assert ti1.state == State.FAILED
+ @mock.patch('airflow.jobs.scheduler_job.TaskCallbackRequest')
+ @mock.patch('airflow.jobs.scheduler_job.Stats.incr')
+ def test_process_executor_events_ti_requeued(self, mock_stats_incr,
mock_task_callback, dag_maker):
+ dag_id = "test_process_executor_events_ti_requeued"
+ task_id_1 = 'dummy_task'
+
+ session = settings.Session()
+ with dag_maker(dag_id=dag_id, fileloc='/test_path1/'):
+ task1 = EmptyOperator(task_id=task_id_1)
+ ti1 = dag_maker.create_dagrun().get_task_instance(task1.task_id)
+
+ mock_stats_incr.reset_mock()
+
+ executor = MockExecutor(do_update=False)
+ task_callback = mock.MagicMock()
+ mock_task_callback.return_value = task_callback
+ self.scheduler_job = SchedulerJob(executor=executor)
+ self.scheduler_job.id = 1
+ self.scheduler_job.processor_agent = mock.MagicMock()
+
+ # ti is queued with another try number - do not fail it
+ ti1.state = State.QUEUED
+ ti1.queued_by_job_id = 1
+ ti1.try_number = 2
+ session.merge(ti1)
+ session.commit()
+
+ executor.event_buffer[ti1.key.with_try_number(1)] = State.SUCCESS, None
+
+ self.scheduler_job._process_executor_events(session=session)
+ ti1.refresh_from_db(session=session)
+ assert ti1.state == State.QUEUED
+ self.scheduler_job.executor.callback_sink.send.assert_not_called()
Review Comment:
Rebased a this should check try number handling
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
