Fokko commented on a change in pull request #4938: [AIRFLOW-4117] Multi-staging Image - Travis CI tests [Step 3/3] URL: https://github.com/apache/airflow/pull/4938#discussion_r293740882
########## File path: scripts/ci/ci_before_install.sh ########## @@ -0,0 +1,34 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +set -xeuo pipefail + +MY_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )" + +export KUBERNETES_VERSION=${KUBERNETES_VERSION:=} +# Required for K8s v1.10.x. See +# https://github.com/kubernetes/kubernetes/issues/61058#issuecomment-372764783 +if [[ ! -z "${KUBERNETES_VERSION}" ]]; then + sudo mount --make-shared / + sudo service docker restart +fi +pip install --upgrade pip Review comment: I believe it is a good idea to run the pylint/doc stuff within the container as well since this will make local development easier. If people want to lint locally, it is easier for people to fire up the docker image, instead of having to fix their system docker to the same version as in the CI. That part I understand, but I don't think upgrading pip is something that we should do, why just not leave as is and use the version that comes with the docker image. In the end, it will take time, and what is the benefit of updating pip? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
