dstandish commented on PR #23658: URL: https://github.com/apache/airflow/pull/23658#issuecomment-1162063256
> yeah thats what i was thinking, added by making the functions private. What i think happens is that the methods that are looking to be mocked are inside a private function. I dont see how to change that behaviour other than making the functions non-private again wellp sorry yeah if they can't be private they can't be private. i just want to minimize surface area of promises we are making. when we have "public" methods we can't change them without deprecation. re > @dstandish i've forgot, but what happens in such case (and same for whenever the pod is deleted for some other external issue that could cause, for example, pod not found) is that the kubectl stream api returns immediately, so this is not an issue (see eg cncf kube pod operator on_kill def). can you clarify... when _what_ happens? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
