uranusjr commented on code in PR #24373:
URL: https://github.com/apache/airflow/pull/24373#discussion_r903311532


##########
newsfragments/24373.improvement.rst:
##########
@@ -0,0 +1 @@
+Support config ``[logging]log_formatter_class`` for overriding 
logging.Formatter

Review Comment:
   We probably only need one of these. Also, this should add a sentence saying 
something like
   
   _If you are using a custom Formatter subclass in your 
[`logging_config_class`](https://airflow.apache.org/docs/apache-airflow/stable/logging-monitoring/logging-tasks.html#advanced-configuration),
 please inherit from `airflow.utils.log.timezone_aware.TimezoneAware` instead 
of `logging.Formatter`_.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to