uranusjr commented on code in PR #24399:
URL: https://github.com/apache/airflow/pull/24399#discussion_r903397755
##########
airflow/www/views.py:
##########
@@ -3541,6 +3544,10 @@ def extra_links(self, session: "Session" = NEW_SESSION):
response = jsonify({'url': None, 'error': 'Task Instances not
found'})
response.status_code = 404
return response
+ if link_name is None:
+ response = jsonify({'url': None, 'error': 'Link name not passed'})
+ response.status_code = 400
+ return response
Review Comment:
Same here (actually I _think_ we can use `requests.args["link_name"]` to
avoid this check?
##########
airflow/www/views.py:
##########
@@ -3541,6 +3544,10 @@ def extra_links(self, session: "Session" = NEW_SESSION):
response = jsonify({'url': None, 'error': 'Task Instances not
found'})
response.status_code = 404
return response
+ if link_name is None:
+ response = jsonify({'url': None, 'error': 'Link name not passed'})
+ response.status_code = 400
+ return response
Review Comment:
Same here; actually I _think_ we can use `requests.args["link_name"]` to
avoid this check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
