uranusjr commented on code in PR #24570:
URL: https://github.com/apache/airflow/pull/24570#discussion_r904525251
##########
tests/hooks/test_dbapi.py:
##########
@@ -44,6 +44,7 @@ def get_conn(self):
return conn
self.db_hook = UnitTestDbApiHook()
+ self.db_hook_log_sql = UnitTestDbApiHook(log_sql=False)
Review Comment:
```suggestion
self.db_hook_no_log_sql = UnitTestDbApiHook(log_sql=False)
```
This should be clearer? But since this is only used by one test, it’s better
to simply instantiate the hook in that test instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
