LaPetiteSouris commented on code in PR #24554:
URL: https://github.com/apache/airflow/pull/24554#discussion_r905416804
##########
tests/providers/amazon/aws/sensors/test_sqs.py:
##########
@@ -305,3 +305,31 @@ def test_poke_do_not_delete_message_on_received(self,
mock_conn):
)
self.sensor.poke(self.mock_context)
assert mock_conn.delete_message_batch.called is False
+
+ @mock_sqs
+ def test_poke_batch_messages(self):
Review Comment:
@eladkal as the`num_batches` feature is added directly to `SqsSensor`, I
added this test.
However, still thinking if this one is enough. The other existing tests look
rather complete to serve as non-regression proof, IMHO.
If you have any other idea about other tests, feel free to suggest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
