dstandish commented on PR #24613: URL: https://github.com/apache/airflow/pull/24613#issuecomment-1164876288
> I would slightly favour a separate `DatasetModel` and `Dataset` so `Dataset` becomes an extensible class, and `DatasetModel` just stores the info about the class. So users don't need to care about SQLAlchmey stuff when extending it. Sure, like i say, don't have a strong feeling. Where would you put it? In the same module? Currently the dataset class doesn't do anything anyway so maybe I'll wait until there's actually something implemented before splitting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
