blag commented on code in PR #24613: URL: https://github.com/apache/airflow/pull/24613#discussion_r905825160
########## airflow/migrations/versions/0113_2_4_0_add_dataset_model.py: ########## @@ -0,0 +1,57 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +"""Add Dataset model + +Revision ID: 0038cd0c28b4 +Revises: 424117c37d18 +Create Date: 2022-06-22 14:37:20.880672 + +""" + +import sqlalchemy as sa +from alembic import op +from sqlalchemy import Integer, func + +from airflow.migrations.db_types import TIMESTAMP, StringID +from airflow.utils.sqlalchemy import ExtendedJSON + +revision = '0038cd0c28b4' +down_revision = '424117c37d18' +branch_labels = None +depends_on = None +airflow_version = '2.4.0' + + +def upgrade(): + """Apply Add Dataset model""" + op.create_table( + 'dataset', + sa.Column('id', Integer, primary_key=True, autoincrement=True), + sa.Column('uri', StringID(length=1000)), Review Comment: We might want to bump this up to at least 2048 (or technically, 2083), since that's what [Internet Explorer and Edge support, and all other browsers support at least 10x that](https://mywebshosting.com/what-is-the-maximum-url-length-limit-in-browsers/). And if we don't care about what browsers support, then we should bump it to at least 4096, since that's what [IIS supports](https://docs.microsoft.com/en-us/iis/configuration/system.webserver/security/requestfiltering/requestlimits/#attributes). If the URI value is supposed to be opaque to Airflow, then I don't see how Airflow can really impose constraints on the value itself. So the only reason to include a length limit is due to database limitations/requirements. Also, since each dataset will be referenced by its URI, does it make sense to make this field unique? URIs are supposed to identify unique things, after all. Doesn't seem to make sense to allow two rows with the same URI in the database, unless we are trying to version datasets. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
