[GitHub] [airflow] bbovenzi opened a new pull request, #24637: Don't render child rows for closed groups

Fri, 24 Jun 2022 08:44:37 -0700 


bbovenzi opened a new pull request, #24637:
URL: https://github.com/apache/airflow/pull/24637

   On DAGs with many task groups, collapsing/expanding a group or selecting a 
task instance can take a really long time. This PR doesn't try to render a any 
child rows is their parent group is closed. This does force us to remove the 
open/close animation. But the page is quite a bit faster on large DAGs with 
many closed groups.
   
   Profiles from 6 runs of a DAG 100 groups of 20 tasks each (2000 task * 6 
runs):
   
   Before:
   <img width="772" alt="Screen Shot 2022-06-24 at 11 17 52 AM" 
src="https://user-images.githubusercontent.com/4600967/175570442-01a66129-b886-482b-8a8a-9315bcf603db.png";>
   
   
   After:
   <img width="550" alt="Screen Shot 2022-06-24 at 11 19 09 AM" 
src="https://user-images.githubusercontent.com/4600967/175570371-b7c511f9-89a0-47a6-888a-6f498c48716f.png";>
   
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a 
newsfragement file, named `{pr_number}.significant.rst`, in 
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to