tanelk commented on code in PR #22976:
URL: https://github.com/apache/airflow/pull/22976#discussion_r907466635
##########
airflow/executors/kubernetes_executor.py:
##########
@@ -689,9 +689,14 @@ def _change_state(self, key: TaskInstanceKey, state:
Optional[str], pod_id: str,
self.event_buffer[key] = state, None
def try_adopt_task_instances(self, tis: List[TaskInstance]) ->
List[TaskInstance]:
- tis_to_flush = [ti for ti in tis if not ti.queued_by_job_id]
- scheduler_job_ids = {ti.queued_by_job_id for ti in tis}
- pod_ids = {ti.key: ti for ti in tis if ti.queued_by_job_id}
+ scheduler_job_ids = {ti.queued_by_job_id for ti in tis if
ti.queued_by_job_id}
+
+ # Tasks triggered through API will have no ti.queued_by_job_id
+ # and their pod will have label 'airflow-worker=manual'
+ if any(ti for ti in tis if not ti.queued_by_job_id):
+ scheduler_job_ids.add('manual')
Review Comment:
I think this check allready covers this:
https://github.com/apache/airflow/blob/c95081406fa47ee737fa7937be4f13e47b2befca/airflow/executors/kubernetes_executor.py#L717-L734
It would be nice to have a UT for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
