pgagnon commented on a change in pull request #5422: [AIRFLOW-4798] obviate
interdependencies for dagbag and TI tests
URL: https://github.com/apache/airflow/pull/5422#discussion_r294090375
##########
File path: tests/models/test_dagbag.py
##########
@@ -194,13 +194,14 @@ def test_get_dag_fileloc(self):
Test that fileloc is correctly set when we load example DAGs,
specifically SubDAGs and packaged DAGs.
"""
- dagbag = models.DagBag(include_examples=True)
+ dagbag = models.DagBag(dag_folder=self.empty_dir,
include_examples=True)
Review comment:
Looks like a great change to me.
One slight nit: I think that you may be able to create this `dagbag` object
in the `setUp` method, which would be slightly more DRY.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
