blag commented on code in PR #24591: URL: https://github.com/apache/airflow/pull/24591#discussion_r909439388
########## airflow/cli/commands/version.py: ########## @@ -0,0 +1,28 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""Version command""" +from rich.console import Console + +import airflow +from airflow.cli import airflow_cmd + + +@airflow_cmd.command('version') +def version(): + """Displays Airflow version at the command line""" + console = Console() Review Comment: I don't disagree that a `Console()` singleton and a single theme/setting would be ideal. But I tried to scope down these PRs to ensure that converting to Click was as "mechanical" of a process as possible. Similar to the pre-commit hook below, I think that is a great idea to do after we convert over to using Click, and I have expanded the "Styling Customization" subsection in [the original omnibus PR description](https://github.com/apache/airflow/pull/22613) to include that. But as below, please let me know if you'd like me to do that now, or if we can defer that to an issue for later work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
