blag commented on code in PR #24591: URL: https://github.com/apache/airflow/pull/24591#discussion_r911465304
########## airflow/cli/__main__.py: ########## @@ -18,6 +18,7 @@ # under the License. from airflow.cli import airflow_cmd +from airflow.cli.commands import version # noqa: F401 Review Comment: In general, it might be more helpful to comment in #22613 if you are making suggestions for future work. A GitHub or mailing list discussion might be more appropriate if you would like more people to explore restructuring the code to better fit other pursuits. And if you would like to provide feedback about the `version` subcommand rewrite, this comment thread, or the general comments for this PR would be great for that. But I'm having difficulty figuring out what the hard requirements _for this PR_ are, what the softer goals of the rewrite as a whole are, and what are proposals for future work. I would like to keep the scope of this PR as small as possible. Is this PR a good Click implementation of the `version` subcommand or not - that's the question here. If we need to pause the Click CLI rewrite and restructure the CLI to resolve other issues first, that's fine. But it seems like major scope creep to go from this `version` subcommand conversion all the way to "research and possibly completely restructure the CLI for an entirely different goal". And if we do have larger re-architecting questions we need to resolve before converting over to Click, then perhaps an AIP and a broader discussion (to capture hard requirements and overall goals of the CLI, and investigate possible alternatives besides just Click) would be appropriate after all. In which case, I will simply close this and all related PRs and wait until there's some consensus on the way forward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
