jedcunningham commented on code in PR #24668:
URL: https://github.com/apache/airflow/pull/24668#discussion_r911456168
##########
chart/Chart.yaml:
##########
@@ -19,7 +19,7 @@
---
apiVersion: v2
name: airflow
-version: 1.7.0-dev
+version: 1.8.0-dev
Review Comment:
```suggestion
version: 1.7.0-dev
```
This should still be 1.7.0-dev. This gets bumped as part of the release
process.
##########
chart/templates/cleanup/cleanup-cronjob.yaml:
##########
@@ -38,9 +38,9 @@ metadata:
chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
release: {{ .Release.Name }}
heritage: {{ .Release.Service }}
-{{- with .Values.labels }}
-{{ toYaml . | indent 4 }}
-{{- end }}
+ {{- if or (.Values.labels) (.Values.cleanup.labels) }}
+ {{- mustMerge .Values.cleanup.labels .Values.labels | toYaml | nindent 4 }}
+ {{- end }}
Review Comment:
I wonder if we should follow the lead of tolerations and
topologySpreadConstraints and do `or .Values.cleanup.labels .Values.labels`
instead of merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
