potiuk commented on code in PR #24782:
URL: https://github.com/apache/airflow/pull/24782#discussion_r912145429


##########
docs/apache-airflow/howto/operator/python.rst:
##########
@@ -60,8 +60,7 @@ is evaluated as a :ref:`Jinja template 
<concepts:jinja-templating>`.
 PythonVirtualenvOperator
 ========================
 
-Use the :class:`~airflow.operators.python.PythonVirtualenvOperator` to execute
-Python callables inside a new Python virtual environment.
+Use the :class:`~airflow.operators.python.PythonVirtualenvOperator` to execute 
Python callables inside a new Python virtual environment. The ``virtualenv`` 
package needs to be installed in the environment that runs Airflow (as optional 
dependency ``pip install airflow[virtualenv]``).

Review Comment:
   ```suggestion
   Use the :class:`~airflow.operators.python.PythonVirtualenvOperator` to 
execute Python callables inside a new Python virtual environment. The 
``virtualenv`` package needs to be installed in the environment that runs 
Airflow (as optional dependency ``pip install airflow[virtualenv] --constraint 
...``).
   ```
   
   Since the only valid (and documented) way to install airflow is with 
constraints, we should add it here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to