[
https://issues.apache.org/jira/browse/AIRFLOW-4800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16865584#comment-16865584
]
ASF GitHub Bot commented on AIRFLOW-4800:
-----------------------------------------
potiuk commented on pull request #5424: [AIRFLOW-4800] fix GKEClusterHook ctor
calls
URL: https://github.com/apache/airflow/pull/5424
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> GKE operators call GKEClusterHook with wrong (old) arguments
> ------------------------------------------------------------
>
> Key: AIRFLOW-4800
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4800
> Project: Apache Airflow
> Issue Type: Bug
> Components: contrib
> Affects Versions: 1.10.3
> Reporter: Ryan Williams
> Assignee: Ryan Williams
> Priority: Minor
>
> [#4364|https://github.com/apache/airflow/pull/4364/files#diff-6c81e7d223790753a57708ed860b51d1R39]
> changed GKEClusterHook's ctor arguments, but not call-sites in
> [GKEClusterDeleteOperator|https://github.com/apache/airflow/blob/2d18f0738f775183b06d19f0b6703285c8bdcb32/airflow/contrib/operators/gcp_container_operator.py#L89]
> and
> [GKEClusterCreateOperator|https://github.com/apache/airflow/blob/2d18f0738f775183b06d19f0b6703285c8bdcb32/airflow/contrib/operators/gcp_container_operator.py#L176].
> [Relevant
> tests|https://github.com/apache/airflow/blob/2d18f0738f775183b06d19f0b6703285c8bdcb32/tests/contrib/operators/test_gcp_container_operator.py#L57-L58]
> still assert that the old arguments are passed.
> I'd have thought that the {{location}} arg being passed to {{delegate_to}}
> would cause real usages of the GKE operators to break, but perhaps it doesn't
> and they are working. I'm not sure what real-world use of these operators is
> like.
> I think the fix is trivial and will PR it shortly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
