potiuk commented on PR #24819: URL: https://github.com/apache/airflow/pull/24819#issuecomment-1173880718
Hey @ephraimbuddy @dstandish - I got the tests for MSSQL workiig for latest SQLalachemy but I am not sure if the solution to the failing tetst were good. There were a number tests added recently to those db migration scripts (good!) and apparently when I migrated to latest sqlalchemy the previous problem mentioned in #21272 is solved but this one tests comparing the schema with the ORM information failled. I am not sure if I fixed it correctly, the root cause of this is likely this one: https://github.com/apache/airflow/blob/main/airflow/migrations/versions/0093_2_2_0_taskinstance_keyed_to_dagrun.py#L278 I believe the CASCADE modification was the problem. Both "diffs" that I ignored had "CASCADE" ondelete, where we are definitely setting NO_ACTION for MsSQL due to the https://docs.microsoft.com/en-us/sql/relational-databases/errors-events/mssqlserver-1785-database-engine-error?view=sql-server-ver15 So I guess for some reason our "diff" script expects CASCADE but gets NO_ACTION, I just ignored the offending differences - similarly to others tests, but maybe this is an indication of some other problem we have (or maybe our diff is not robust enough to account for differences between the dialects?) Any insight and comments (and maybe approval if I did it correctly) is appreciated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
