Fokko commented on a change in pull request #5079: [AIRFLOW-4285] Update task dependency context defination and usage URL: https://github.com/apache/airflow/pull/5079#discussion_r294343516
########## File path: airflow/ti_deps/deps/dagrun_id_dep.py ########## @@ -0,0 +1,42 @@ +# -*- coding: utf-8 -*- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from re import match + +from airflow.ti_deps.deps.base_ti_dep import BaseTIDep +from airflow.utils.db import provide_session + + +class DagrunIdDep(BaseTIDep): + NAME = "Dagrun run_id is not backfill job ID" + IGNOREABLE = True + + @provide_session Review comment: Why should we provide the session here, we could do it in the `get_dagrun` function directly, since it isn't used in the is function anywhere else. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
