potiuk commented on a change in pull request #5426: [AIRFLOW-4765] Fix DataProcPigOperator execute method URL: https://github.com/apache/airflow/pull/5426#discussion_r294356179
########## File path: airflow/contrib/example_dags/example_gcp_dataproc_pig_operator.py ########## @@ -0,0 +1,67 @@ +# -*- coding: utf-8 -*- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +""" +Example Airflow DAG for Google Dataproc PigOperator Review comment: Yep. I imagine AIP-4 works as plugginable extension to breeze/docker we have in Airflow. Then anyone testing their own services will be able to have their own automated CI running their own system tests using their own CI of choice (for example in our case - using Cloud Build). Without polluting the main Airflow code/tests or examples. I will do it in the way that you might have it living completely outside of the main airflow repo - and you will be able to evolve it separately. So it all fits very well and I am sure we will find a good resting place for the dags ;). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
