potiuk opened a new pull request, #24871: URL: https://github.com/apache/airflow/pull/24871
The "fix-ownership" command uses our breeze docker image to fix ownership of files generated by breeze. This is nice from the user perspective because there is no need to authenticate with password and - since we already have breeze image handy - it is fast and painless. However in CI, there are often cases where "fix-ownership" does not really have an image available and needs to pull one, which takes 1 minute. However the user in CI has sudoer capability without password, so we can use it to run fix-ownership with just plain sudo/chown. We switch all the CI jobs to "USE_SUDO" and also avoid running fix-ownership on other systems that Linux, as the ownership of files creaed from docker as root is only problem when the filesystem is directly mounted and used in the container (which happens only on Linux). MacOS and Windows have "user-space" filesystem that are much slower, but then they perform user-remapping on their own and files created in container have automatically ownership of the user who runs the docker container command. <!-- Thank you for contributing! Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping committers for the review! In case of an existing issue, reference it using one of the following: closes: #ISSUE related: #ISSUE How to write a good git commit message: http://chris.beams.io/posts/git-commit/ --> --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information. In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
