ashb commented on code in PR #24743:
URL: https://github.com/apache/airflow/pull/24743#discussion_r915711168
##########
airflow/utils/types.py:
##########
@@ -45,6 +45,7 @@ class DagRunType(str, enum.Enum):
BACKFILL_JOB = "backfill"
SCHEDULED = "scheduled"
MANUAL = "manual"
+ DATASE = "dataset"
Review Comment:
a)
```suggestion
DATASET = "dataset"
```
b) also this isn't quite the right name (as in it doesn't quite capture the
meaning of what is happening). How about something like one of these
```python
DATASET_TRIGGERED = "dataset_triggered"
TRIGGERED = "triggered"
DATASET_SCHEDULED = "dataset_scheduled"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
