rossturk commented on PR #629: URL: https://github.com/apache/airflow-site/pull/629#issuecomment-1179329854
> Just a thought @rossturk . Since this is golang mostly and yarn - we do not TECHNICALLY need to run everything with Docker. I think teh set of technologies we use to build "airflow-site" is "multi-patform enough" to not require Docker image? Yeah, I think this could be possible. With homebrew/apt/yum and venv we can probably create a fairly portable build environment. But I still find a lot of benefit in a containerized process. It ensures consistency between the dev's local environment and the one inside CI. Right now the build is failing on this PR and I think it's because I updated `python` to `python3` in a few spots in `site.sh`. I did this because one of the systems I test on has both python 2 and 3 installed, and the symlink for `python` was pointing to 2. I feel it's better to be explicit about python versions, generally. Of course, now I am solving a problem on my local machine that doesn't exist in CI, and along the way I am now suspecting I might have broken CI! This wouldn't be a problem if those steps in `site.sh` ran inside the container. But the current process spans the container + the local environment. So we're somewhat missing the benefit. On one of the other sites I manage, we support local environments as you suggest. It's easy to work with. However, one consequence is that certain components of node behave differently on different environments, leading to YAML files that contain the same information but constantly switch order, etc., creating lots of git noise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
