dstandish commented on code in PR #24625:
URL: https://github.com/apache/airflow/pull/24625#discussion_r917907268
##########
airflow/providers/microsoft/azure/hooks/asb.py:
##########
@@ -114,6 +119,93 @@ def delete_queue(self, queue_name: str) -> None:
with self.get_conn() as service_mgmt_conn:
service_mgmt_conn.delete_queue(queue_name)
+ def create_subscription(
Review Comment:
yes that was the suggestion. but i don't have strong feelings if you want
to go this way and you've already got an approval so it's up to you.
i am just of the philosophy that when the client methods already do exactly
what we need, we don't need to implement those exact methods. mainly it's for
autocomplete i guess? to me it seems simpler to just use the methods and let
the hook be lighter weight and reduce our maintenance burden. on the other
hand, i understand there's an argument that implementing methods like this aids
in discoverability of features for users, and is worth it despite adding code
that doesn "need" to be there.
related note, for AWS we have a good type stubs library that we use instead
of doing this. in other cases i have seen use of `Protocol` classes to add
autocomplete.
anyway, up to you as far as i'm concerned. lemme know your thoughts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
