josh-fell commented on code in PR #24931:
URL: https://github.com/apache/airflow/pull/24931#discussion_r917039113
##########
tests/providers/google/cloud/utils/gcp_authenticator.py:
##########
@@ -107,8 +107,8 @@ def set_key_path_in_airflow_connection(self):
extras[PROJECT_EXTRA] = self.project_extra if self.project_extra
else self.project_id
conn.extra = json.dumps(extras)
session.commit()
- except BaseException as ex:
- self.log.error('Airflow DB Session error: %s', str(ex))
+ except BaseException:
+ self.log.error('Airflow DB Session error.')
Review Comment:
I thought that the `raise` was sufficient here for the additional traceback
information which includes the exception message. Generally I was thinking to
keep `logging.error()` when there was an accompanying `raise`, but use
`logging.exception()` or using `exc_info=True` when there isn't. Happy to hear
other thoughts of course!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
