eladkal commented on code in PR #24576:
URL: https://github.com/apache/airflow/pull/24576#discussion_r919388074
##########
docs/helm-chart/manage-dags-files.rst:
##########
@@ -71,12 +71,18 @@ Finally, update the Airflow pods with that image:
If you are deploying an image with a constant tag, you need to make sure that
the image is pulled every time.
+.. warning::
+
+ Using constant tag should be used only for testing/development purpose. It
is a bad practice to use the same tag as you'll lose the history of your code.
+
.. code-block:: bash
helm upgrade --install airflow apache-airflow/airflow \
--set images.airflow.repository=my-company/airflow \
--set images.airflow.tag=8a0da78 \
- --set images.airflow.pullPolicy=Always
+ --set images.airflow.pullPolicy=Always \
+ --set airflowPodAnnotations.random=r$(uuidgen)
+The randomly generated pod annotation will ensure that pods are refreshed on
helm upgrade.
Review Comment:
```suggestion
--set airflowPodAnnotations.random=r$(uuidgen)
The randomly generated pod annotation will ensure that pods are refreshed on
helm upgrade.
```
missing a blank line after markup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
