pankajkoti commented on code in PR #24967:
URL: https://github.com/apache/airflow/pull/24967#discussion_r920887030
##########
airflow/providers/http/sensors/http.py:
##########
@@ -91,15 +100,26 @@ def __init__(
self.headers = headers or {}
self.extra_options = extra_options or {}
self.response_check = response_check
-
- self.hook = HttpHook(method=method, http_conn_id=http_conn_id)
Review Comment:
@potiuk Is there a specific reason we would like to remove this assignment
to the instance and are only creating the hook at a later stage in the `poke`
method excluding it as an instance variable?
The async operator relies on this instance variable:
https://github.com/astronomer/astronomer-providers/blob/main/astronomer/providers/http/sensors/http.py#L67
and the RC is failing for the current async implementation.
Should we create a new hook instance in the derived class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
